Add AssertSameDifferentTypesRuleTest #3
Conversation
ondrejmirtes
left a comment
ondrejmirtes
left a comment
There was a problem hiding this comment.
Awesome, thanks! I found a few minor issues 😊
| $this->assertSame('1', 1); | ||
| $this->assertSame('1', new \stdClass()); | ||
| $this->assertSame(1, $this->returnsString()); | ||
| $this->assertSame('1', self::returnsInt()); |
There was a problem hiding this comment.
There should also be a few examples of positive cases - comparing int/int and probably also comparing some unions against simple type and unions against unions.
| @@ -0,0 +1,39 @@ | |||
| <?php | |||
|
|
|||
| declare(strict_types = 1); | |||
There was a problem hiding this comment.
Please put declare on the same line as <?php :)
|
|
||
| declare(strict_types = 1); | ||
|
|
||
| namespace PHPUnit; |
There was a problem hiding this comment.
Please use a different namespace, something like namespace ExampleTestCase is fine 😊
There was a problem hiding this comment.
The intention was to make it consistent with https://github.com/phpstan/phpstan-strict-rules/blob/master/tests/Rules/StrictCalls/data/strict-calls.php
There was a problem hiding this comment.
Yeah, but PHPUnit is a well known and used namespace :)
| $this->assertSame(1, self::returnsInt()); | ||
|
|
||
| // this breaks PHPStan | ||
| $this->assertSame(['a'], ['a', 1]); |
There was a problem hiding this comment.
@ondrejmirtes this line breaks PHPStan
PHPStan\ShouldNotHappenException : Internal error.
C:\devweb\htdocs\phpstan-phpunit\vendor\phpstan\phpstan\src\Type\TypeCombinator.php:23
C:\devweb\htdocs\phpstan-phpunit\vendor\phpstan\phpstan\src\Type\ArrayType.php:28
C:\devweb\htdocs\phpstan-phpunit\vendor\phpstan\phpstan\src\Analyser\Scope.php:575
C:\devweb\htdocs\phpstan-phpunit\vendor\phpstan\phpstan\src\Analyser\Scope.php:323
C:\devweb\htdocs\phpstan-phpunit\src\Rules\PHPUnit\AssertSameDifferentTypesRule.php:62
C:\devweb\htdocs\phpstan-phpunit\vendor\phpstan\phpstan\src\Analyser\Analyser.php:162
C:\devweb\htdocs\phpstan-phpunit\vendor\phpstan\phpstan\src\Analyser\NodeScopeResolver.php:316
C:\devweb\htdocs\phpstan-phpunit\vendor\phpstan\phpstan\src\Analyser\NodeScopeResolver.php:176
C:\devweb\htdocs\phpstan-phpunit\vendor\phpstan\phpstan\src\Analyser\NodeScopeResolver.php:686
C:\devweb\htdocs\phpstan-phpunit\vendor\phpstan\phpstan\src\Analyser\NodeScopeResolver.php:176
C:\devweb\htdocs\phpstan-phpunit\vendor\phpstan\phpstan\src\Analyser\NodeScopeResolver.php:686
C:\devweb\htdocs\phpstan-phpunit\vendor\phpstan\phpstan\src\Analyser\NodeScopeResolver.php:176
C:\devweb\htdocs\phpstan-phpunit\vendor\phpstan\phpstan\src\Analyser\NodeScopeResolver.php:686
C:\devweb\htdocs\phpstan-phpunit\vendor\phpstan\phpstan\src\Analyser\NodeScopeResolver.php:176
C:\devweb\htdocs\phpstan-phpunit\vendor\phpstan\phpstan\src\Analyser\Analyser.php:166
C:\devweb\htdocs\phpstan-phpunit\vendor\phpstan\phpstan\src\Testing\RuleTestCase.php:64
C:\devweb\htdocs\phpstan-phpunit\tests\Rules\PHPUnit\AssertSameDifferentTypesRuleTest.php:19
There was a problem hiding this comment.
fixed by enabling union types in tests bootstrap
|
R4R @ondrejmirtes |
|
Awesome! :) |
2 participants
I wanted to have a look on how to write PHPStan rules tests and I found none in this repository. So I created one.