Expand AssertSameWithCountRule to support sizeof

README.md

@@ -23,7 +23,7 @@ It also contains this strict framework-specific rules (can be enabled separately
 * Check that you are not using `assertSame()` with `true` as expected value. `assertTrue()` should be used instead.
 * Check that you are not using `assertSame()` with `false` as expected value. `assertFalse()` should be used instead.
 * Check that you are not using `assertSame()` with `null` as expected value. `assertNull()` should be used instead.
-* Check that you are not using `assertSame()` with `count($variable)` as second parameter. `assertCount($variable)` should be used instead.
+* Check that you are not using `assertSame()` with `count($variable)`, or its alias `sizeof($variable)`, as second parameter. `assertCount($variable)` should be used instead.
 
 ## How to document mock objects in phpDocs?
 

src/Rules/PHPUnit/AssertSameWithCountRule.php

@@ -36,10 +36,13 @@ public function processNode(Node $node, Scope $scope): array
 		if (
 			$right instanceof Node\Expr\FuncCall
 			&& $right->name instanceof Node\Name
-			&& strtolower($right->name->toString()) === 'count'
+			&& in_array(strtolower($right->name->toString()), ['count', 'sizeof'], true)
 		) {
 			return [
-				'You should use assertCount($expectedCount, $variable) instead of assertSame($expectedCount, count($variable)).',
+				sprintf(
+					'You should use assertCount($expectedCount, $variable) instead of assertSame($expectedCount, %s($variable)).',
+					strtolower($right->name->toString())
+				),
 			];
 		}
 

tests/Rules/PHPUnit/AssertSameWithCountRuleTest.php

@@ -19,6 +19,10 @@ public function testRule(): void
 				'You should use assertCount($expectedCount, $variable) instead of assertSame($expectedCount, count($variable)).',
 				10,
 			],
+			[
+				'You should use assertCount($expectedCount, $variable) instead of assertSame($expectedCount, sizeof($variable)).',
+				20,
+			],
 		]);
 	}
 

tests/Rules/PHPUnit/data/assert-same-count.php

@@ -15,4 +15,13 @@ public function testAssertSameWithCountMethodIsOK()
 		$this->assertSame(5, $this->count()); // OK
 	}
 
+	public function testAssertSameWithSizeOf()
+	{
+		$this->assertSame(5, sizeof([1, 2, 3]));
+	}
+
+	public function testAssertSameWithSizeOfMethodIsOK()
+	{
+		$this->assertSame(5, $this->sizeof()); // OK
+	}
 }