Skip to content

Add reformat command #147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Add reformat command #147

wants to merge 2 commits into from

Conversation

@Erikvv
Copy link

@Erikvv Erikvv commented Feb 28, 2020 •
edited
Loading

What's this?

Add command to transform json output into other formats.
This allows to do 1 run, and then produce different outputs.
This saves some compute resources for large projects.

Example:

phpstan analyse --error-format json src/ > output.json
cat output.json | phpstan reformat --error-format table > output.txt
cat output.json | phpstan reformat --error-format baselineNeon > baseline.neon

Testing

@Erikvv Erikvv changed the title Add reformat command [WIP] Add reformat command Feb 28, 2020
@ondrejmirtes
Copy link
Member

ondrejmirtes commented Feb 28, 2020

Yes! 😍 I had this in my todolist :)

ondrejmirtes
ondrejmirtes requested changes Feb 28, 2020
View reviewed changes
Copy link
Member

@ondrejmirtes ondrejmirtes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Plus fix the build failures. Thank you.

@Erikvv
Copy link
Author

Erikvv commented Feb 28, 2020

Thanks for your feedback I addressed it all.

@Erikvv Erikvv changed the title [WIP] Add reformat command Add reformat command Feb 28, 2020
ondrejmirtes
ondrejmirtes requested changes Feb 28, 2020
View reviewed changes
Copy link
Member

@ondrejmirtes ondrejmirtes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few more fixes to do :)

@Erikvv
Copy link
Author

Erikvv commented Mar 13, 2020

Sorry for delay, I was having some time off.

Rebased and feedback processed.

@ondrejmirtes ondrejmirtes force-pushed the master branch 5 times, most recently from dc2e229 to 1d0d3ad Compare March 17, 2020 14:14
@Erikvv
Copy link
Author

Erikvv commented Apr 24, 2020

@ondrejmirtes any chance this can be merged?

@ondrejmirtes ondrejmirtes deleted the branch phpstan:master March 12, 2022 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ondrejmirtes ondrejmirtes ondrejmirtes requested changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Erikvv @ondrejmirtes