Skip to content

Conversation

@staabm
Copy link
Contributor

@staabm staabm commented Jun 24, 2022

add a e2e test for the resultCachePath parameter to prevent regressions in #1469.
I had the impression this feature is currently not covered by tests.

to cover the case mentioned in phpstan/phpstan#7379 (comment)

@staabm staabm marked this pull request as ready for review June 24, 2022 14:16
@staabm staabm marked this pull request as draft June 24, 2022 15:40
@staabm staabm marked this pull request as ready for review June 24, 2022 18:37
@staabm staabm force-pushed the test-result-cache-path branch from 745b43c to 87c6427 Compare June 26, 2022 16:27
@staabm
Copy link
Contributor Author

staabm commented Jun 29, 2022

@ondrejmirtes do you see a chance we can get this one merged?

I want to built new result-cache tests on top of it

@staabm staabm force-pushed the test-result-cache-path branch from 87c6427 to d08c30d Compare June 29, 2022 14:34
@clxmstaab clxmstaab force-pushed the test-result-cache-path branch from d08c30d to 3c6faf2 Compare June 29, 2022 14:37
@staabm staabm changed the base branch from 1.7.x to 1.8.x June 29, 2022 14:37
@staabm staabm force-pushed the test-result-cache-path branch from 3c6faf2 to 6106e3d Compare June 29, 2022 14:37
@ondrejmirtes
Copy link
Member

Perfect, thank you!

@ondrejmirtes ondrejmirtes merged commit d82d7e7 into phpstan:1.8.x Jun 30, 2022
@staabm staabm deleted the test-result-cache-path branch June 30, 2022 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants