Skip to content

Conversation

@fezfez
Copy link

@fezfez fezfez commented Nov 21, 2019

No description provided.

@ondrejmirtes
Copy link
Member

This isn’t neccesary. PHPStan 0.12 in phpstan/phpstan package won’t have the dependency on Symfony.

If it’s a blocker for you right now, install the current stable version of phpstan/phpstan-shim.

@fezfez
Copy link
Author

fezfez commented Nov 24, 2019

@ondrejmirtes thanks for the quick response, Have you scheduled a date for the version?

@ondrejmirtes
Copy link
Member

Yes, December 3rd.

@ondrejmirtes ondrejmirtes mentioned this pull request Nov 24, 2019
@emodric
Copy link

emodric commented Nov 25, 2019

@ondrejmirtes 0.11.19 release of phpstan/phpstan does not allow Symfony 5.0. Could 0.11.20 be tagged which allows Symfony 5 for projects that will not upgrade to PhpStan 0.12 right away?

@ondrejmirtes
Copy link
Member

@emodric
Copy link

emodric commented Nov 25, 2019

@ondrejmirtes I'm sorry if I'm missunderstanding something, but how do I use rule packs (like strict rules or phpunit rules) with the shim package, since they all depend on phpstan/phpstan?

@ondrejmirtes
Copy link
Member

ondrejmirtes commented Nov 25, 2019 via email

@emodric
Copy link

emodric commented Nov 25, 2019

Oh, the shim package replaces phpstan/phpstan in Composer :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants