Skip to content

Conversation

@szepeviktor
Copy link
Contributor

@szepeviktor szepeviktor commented Aug 27, 2020

Copy link
Member

@ondrejmirtes ondrejmirtes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, it works, but it uses a PHP client, to the guide you linked :)

COVERALLS_REPO_TOKEN: ${{ secrets.GITHUB_TOKEN }}
run: |
composer require twinh/php-coveralls --dev && \
vendor/bin/php-coveralls --verbose --coverage_clover=tests/tmp/clover.xml --json_path=tests/tmp/coveralls-upload.json
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you try following the custom GItHub Action guide instead: https://github.com/marketplace/actions/coveralls-github-action

Copy link
Contributor Author

@szepeviktor szepeviktor Aug 27, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That GitHub Action is for LCOV formatted coverage only.
I've tried that, please see the 2nd commit.

[error] "2020-08-27T02:10:55.888Z"  'error from lcovParse: ' 'Failed to parse string'
[error] "2020-08-27T02:10:55.889Z"  'input: ' '<?xml version="1.0" encoding="UTF-8"?>\n' +

https://github.com/phpstan/phpstan-src/runs/1034404107

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's an official github action repo by coveralls but it seems to be for js based projects only coverallsapp/github-action.

php-coveralls/php-coveralls#273 (comment)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, that's why I wasn't successful previously. Thanks.

@ondrejmirtes
Copy link
Member

Also, you can clean up the current Codecov config.

@szepeviktor
Copy link
Contributor Author

Okay!

Success :)

Coverage:  84.51% (20811/24626)
Collect git info
Read environment variables
Dump submitting json file: /home/runner/work/phpstan-src/phpstan-src/tests/tmp/coveralls-upload.json
File size: 2,458.04 kB
Submitting to https://coveralls.io/api/v1/jobs
Finish submitting. status: 200 OK
Accepted Job #226389376.1
You can see the build on https://coveralls.io/jobs/66907835
elapsed time: 2.262 sec memory: 16.00 MB

https://coveralls.io/jobs/66907835

@ondrejmirtes ondrejmirtes merged commit ca82622 into phpstan:master Aug 28, 2020
@szepeviktor
Copy link
Contributor Author

Thank you.

@szepeviktor szepeviktor deleted the patch-2 branch August 28, 2020 11:25
@szepeviktor
Copy link
Contributor Author

The badge just lit up :)

kép

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants