Skip to content

Send coverage to Coveralls #308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Aug 28, 2020
Merged

Send coverage to Coveralls #308

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
26ff9b4
Send coverage to Coveralls
szepeviktor Aug 27, 2020
3af71ba
Add clover.xml path
szepeviktor Aug 27, 2020
17ae42f
Update build.yml
szepeviktor Aug 27, 2020
851a7f8
Update build.yml
szepeviktor Aug 27, 2020
3c52a41
Update build.yml
szepeviktor Aug 27, 2020
2e57dd5
Add Coveralls badge
szepeviktor Aug 27, 2020
643298b
Delete codecov.yml
szepeviktor Aug 27, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -188,10 +188,12 @@ jobs:
vendor/bin/pcov clobber && \
php -dpcov.enabled=1 -dpcov.directory=. -dpcov.exclude="~vendor~" vendor/bin/phpunit -c tests/phpunit.xml tests/PHPStan

- name: "Codecov.io"
- name: "Coveralls"
env:
CODECOV_TOKEN: "${{ secrets.CODECOV_TOKEN }}"
run: "bash <(curl -s https://codecov.io/bash) -f tests/tmp/clover.xml"
COVERALLS_REPO_TOKEN: ${{ secrets.GITHUB_TOKEN }}
run: |
composer require twinh/php-coveralls --dev && \
vendor/bin/php-coveralls --verbose --coverage_clover=tests/tmp/clover.xml --json_path=tests/tmp/coveralls-upload.json
Copy link
Member

@ondrejmirtes ondrejmirtes Aug 27, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you try following the custom GItHub Action guide instead: https://github.com/marketplace/actions/coveralls-github-action

Copy link
Contributor Author

@szepeviktor szepeviktor Aug 27, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That GitHub Action is for LCOV formatted coverage only.
I've tried that, please see the 2nd commit.

[error] "2020-08-27T02:10:55.888Z"  'error from lcovParse: ' 'Failed to parse string'
[error] "2020-08-27T02:10:55.889Z"  'input: ' '<?xml version="1.0" encoding="UTF-8"?>\n' +

https://github.com/phpstan/phpstan-src/runs/1034404107

Copy link
Contributor Author

@szepeviktor szepeviktor Aug 27, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's an official github action repo by coveralls but it seems to be for js based projects only coverallsapp/github-action.

php-coveralls/php-coveralls#273 (comment)

Copy link
Member

@ondrejmirtes ondrejmirtes Aug 28, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, that's why I wasn't successful previously. Thanks.


static-analysis:
name: "PHPStan"
Expand Down
1 change: 1 addition & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

[![Build Status](https://travis-ci.com/phpstan/phpstan-src.svg?branch=master)](https://travis-ci.com/phpstan/phpstan-src)
[![Build](https://github.com/phpstan/phpstan-src/workflows/Build/badge.svg)](https://github.com/phpstan/phpstan-src/actions)
[![Coverage Status](https://coveralls.io/repos/github/phpstan/phpstan-src/badge.svg)](https://coveralls.io/github/phpstan/phpstan-src)
[![PHPStan Enabled](https://img.shields.io/badge/PHPStan-enabled-brightgreen.svg?style=flat)](https://github.com/phpstan/phpstan)

---
Expand Down
4 changes: 0 additions & 4 deletions codecov.yml
View file
Open in desktop

This file was deleted.