No cp phpstan (phpstan.phar without ext)#425
Closed
mvorisek wants to merge 4 commits into
Closed
Conversation
mvorisek
commented
Jan 18, 2021
| 'finders' => [], | ||
| 'files-whitelist' => $stubs, | ||
| 'patchers' => [ | ||
| function (string $filePath, string $prefix, string $content): string { |
Contributor
Author
There was a problem hiding this comment.
this is not needed, git blame did not advise any need/issue in the past with it
if so, please let me know
Member
There was a problem hiding this comment.
/cc @lookyman Could you remember what was the reason to include this patcher in the original phpstan-compiler? :) Thanks.
Contributor
Author
|
is the CI error related with this PR? |
Member
|
No. |
staabm
reviewed
Jan 19, 2021
Member
|
I cherry-picked the relevant commit, thank you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
merge after phpstan/phpstan#4390
1/2 PR for phpstan/phpstan#4389