Skip to content

Update PHPStan packages / Fix PHP 7.4 sprintf() type errors #4464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
+19 −14
Closed

Update PHPStan packages / Fix PHP 7.4 sprintf() type errors #4464

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8f88082
Update PHPStan packages to v2.0.6
renovate[bot] Oct 21, 2025
113a97a
Narrow FileCacheStorage $directory
staabm Oct 21, 2025
7b250db
Parameter #3 of function sprintf is expected to be string by placehol…
staabm Oct 21, 2025
29fd095
try different fix
staabm Oct 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 13 additions & 13 deletions composer.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 3 additions & 0 deletions src/Cache/FileCacheStorage.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,9 @@

private const CACHED_CLEARED_VERSION = 'v2-new';

/**
* @param non-empty-string $directory
*/
public function __construct(private string $directory)
{
}
Expand Down Expand Up @@ -114,7 +117,7 @@

return [
$firstDirectory,
$secondDirectory,

Check failure on line 120 in src/Cache/FileCacheStorage.php

View workflow job for this annotation

GitHub Actions / PHPStan (7.4, ubuntu-latest) 

Parameter #3 of function sprintf is expected to be string by placeholder #2 ("%s"), string|false given.

Check failure on line 120 in src/Cache/FileCacheStorage.php

View workflow job for this annotation

GitHub Actions / PHPStan (7.4, windows-latest) 

Parameter #3 of function sprintf is expected to be string by placeholder #2 ("%s"), string|false given.
$filePath,
];
}
Expand Down
4 changes: 3 additions & 1 deletion src/Rules/Cast/InvalidCastRule.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
use PHPStan\Rules\Rule;
use PHPStan\Rules\RuleErrorBuilder;
use PHPStan\Rules\RuleLevelHelper;
use PHPStan\ShouldNotHappenException;
use PHPStan\Type\ErrorType;
use PHPStan\Type\Type;
use PHPStan\Type\VerbosityLevel;
Expand Down Expand Up @@ -82,15 +83,16 @@
if ($castType instanceof ErrorType) {
$classReflection = $this->reflectionProvider->getClass(get_class($node));
$shortName = $classReflection->getNativeReflection()->getShortName();

$shortName = strtolower($shortName);
if ($shortName === 'double') {
$shortName = 'float';
} else {
} elseif ($shortName !== '') {
$shortName = substr($shortName, 0, -1);
}

return [
RuleErrorBuilder::message(sprintf(

Check failure on line 95 in src/Rules/Cast/InvalidCastRule.php

View workflow job for this annotation

GitHub Actions / PHPStan (7.4, ubuntu-latest) 

Parameter #3 of function sprintf is expected to be string by placeholder #2 ("%s"), string|false given.

Check failure on line 95 in src/Rules/Cast/InvalidCastRule.php

View workflow job for this annotation

GitHub Actions / PHPStan (7.4, windows-latest) 

Parameter #3 of function sprintf is expected to be string by placeholder #2 ("%s"), string|false given.
'Cannot cast %s to %s.',
$scope->getType($node->expr)->describe(VerbosityLevel::value()),
$shortName,
Expand Down
Loading