Create PhpParserExpr.stub #4503
Conversation
| $parameters = null; | ||
| $singleParametersAcceptor = null; | ||
| if (count($parametersAcceptors) === 1) { | ||
| if (!array_is_list($args)) { |
There was a problem hiding this comment.
doing a runtime check, to not change the phpdoc on a @api class
There was a problem hiding this comment.
Well this is worse because suddenly you're throwing an exception for a valid input advertised by the signature.
If it's not a list, let's make it a list.
There was a problem hiding this comment.
Great idea.
It might even be worth creating a new rule which errors in my wrong code example?
There was a problem hiding this comment.
Not sure how to express the logic you'd want...
There was a problem hiding this comment.
Error on conditions which always lead to unchecked exceptions, when the conditions narrows a parameter type.
But you are right, maybe too specific
There was a problem hiding this comment.
I'd merge this if you call array_values here instead 😊
There was a problem hiding this comment.
was not at the computer until now. fix incoming ;).
There was a problem hiding this comment.
I'm also outside the entire time 😂
|
This pull request has been marked as ready for review. |
|
Thank you! |
3 participants
fixes "~140 offset might not exist" errors