Skip to content

Conversation

@schlndh
Copy link
Contributor

@schlndh schlndh commented Oct 31, 2025

Fixes https://phpstan.org/r/da494451-a17d-49f9-bcb7-5b2ce11219d2

It's covered by ReflectionProviderGoldenTest so I didn't add any other test:

1) PHPStan\Reflection\ReflectionProviderGoldenTest::test with data set "PROPERTY BcMath\Number::$value" ('PROPERTY BcMath\Number::$value', 'Readonly\nVisibility: public\...string')
Failed asserting that two strings are identical.
--- Expected
+++ Actual
@@ @@
 'Readonly
 Visibility: public
-Read type: string
-Write type: string'
+Read type: numeric-string
+Write type: numeric-string'

@ondrejmirtes ondrejmirtes merged commit ae9d277 into phpstan:2.1.x Oct 31, 2025
540 of 555 checks passed
@ondrejmirtes
Copy link
Member

Thank you!

@schlndh schlndh deleted the fix-bcMathNumberValueType branch October 31, 2025 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants