Fix broken array_count_values array key inference#4798
Closed
staabm wants to merge 2 commits intophpstan:2.1.xfrom
Closed
Fix broken array_count_values array key inference#4798staabm wants to merge 2 commits intophpstan:2.1.xfrom
array_count_values array key inference#4798staabm wants to merge 2 commits intophpstan:2.1.xfrom
Conversation
| continue; | ||
| } | ||
|
|
||
| if (!$itemType->isString()->no() && !$itemType->isConstantScalarValue()->yes()) { |
Contributor
There was a problem hiding this comment.
I feel like you're creating lot of weird inferences:
'foo'|int will be resume tostring|int`- 'non-empty-string|int' lose the non-empty accessory (same for non-falsy)
Same for 'foo'|positive-int or 'non-falsy-string|positive-int' ; if later casted to array they both are non-falsy while it's not the case if they are resumed to a simple int|string.
Then I'm unsure if this fix is doing more good than bad and shouldn't wait for a more general bugfix (?), cf phpstan/phpstan#13996 (comment)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes phpstan/phpstan#13996