Skip to content

ClassNameCheck: Retrieve extensions just once #5027

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ondrejmirtes merged 3 commits into from
Feb 22, 2026
+6 −3
Merged

ClassNameCheck: Retrieve extensions just once #5027

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b0353fe
ClassNameCheck: Retrieve extensions just once
staabm Feb 22, 2026
ce50db7
Update InstantiationRule.php
staabm Feb 22, 2026
ae565f0
Update InstantiationRule.php
staabm Feb 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions src/Rules/Classes/InstantiationRule.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,9 @@
final class InstantiationRule implements Rule
{

/** @var RestrictedMethodUsageExtension[] $extensions */
private ?array $extensions = null;

public function __construct(
private Container $container,
private ReflectionProvider $reflectionProvider,
Expand Down Expand Up @@ -207,10 +210,10 @@ private function checkClassName(string $class, bool $isName, Node $node, Scope $
->build();
}

/** @var RestrictedMethodUsageExtension[] $restrictedUsageExtensions */
$restrictedUsageExtensions = $this->container->getServicesByTag(RestrictedMethodUsageExtension::METHOD_EXTENSION_TAG);
/** @var RestrictedMethodUsageExtension[] $extensions */
$extensions = $this->extensions ??= $this->container->getServicesByTag(RestrictedMethodUsageExtension::METHOD_EXTENSION_TAG);

foreach ($restrictedUsageExtensions as $extension) {
foreach ($extensions as $extension) {
$restrictedUsage = $extension->isRestrictedMethodUsage($constructorReflection, $scope);
if ($restrictedUsage === null) {
continue;
Expand Down
Loading