Skip to content

Conversation

@mvorisek
Copy link
Contributor

60 seconds is not enought for larger projects.

Improve UX with implicit larget timeout by default. 30 minutes timeout should still be below the typical CI timeouts to catch unexpected errors in phpstan and get them displayed.

@ondrejmirtes
Copy link
Member

Personally I've never had this problem. The option is already configurable so I don't see a reason to change the default. The timeout is here to tell the user that something is wrong.

Good way to fix the root cause would be for the child worker process to inform the parent process more often about not being stuck.

@mvorisek
Copy link
Contributor Author

Good way to fix the root cause would be for the child worker process to inform the parent process more often about not being stuck.

sounds great, even one huge file can need more time limit - If phpstan can emit something when moved to the next token/line, that can be a solution, but I have no phpstan internals knowledge to do that

@mvorisek mvorisek deleted the patch-2 branch May 31, 2021 15:51
@ondrejmirtes
Copy link
Member

If processing one file takes longer than 60 seconds, you should rather exclude it from the analysis.

@mvorisek
Copy link
Contributor Author

I do not agree - phpstan is a tool and there are legit usecases with huge files. And that usecases should idealy be covered with default configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants