Test result-cache restore does not trigger reflection in all 1st party extensions#5618
Merged
staabm merged 1 commit intophpstan:2.1.xfrom May 9, 2026
Merged
Test result-cache restore does not trigger reflection in all 1st party extensions#5618staabm merged 1 commit intophpstan:2.1.xfrom
staabm merged 1 commit intophpstan:2.1.xfrom
Conversation
staabm
commented
May 9, 2026
Comment on lines
+5
to
+11
| "phpstan/phpstan-doctrine": "@dev", | ||
| "phpstan/phpstan-beberlei-assert": "@dev", | ||
| "phpstan/phpstan-phpunit": "@dev", | ||
| "phpstan/phpstan-webmozart-assert": "@dev", | ||
| "phpstan/phpstan-mockery": "@dev", | ||
| "phpstan/phpstan-nette": "@dev", | ||
| "phpstan/phpstan-dibi": "@dev", |
Contributor
Author
There was a problem hiding this comment.
I am using a @dev constraint to make sure this test will not stop covering latest versions of the plugin, in case they will release new major versions.
(so we make sure noone needs to remember to adjust this tests' composer.json to cover it)
staabm
added a commit
that referenced
this pull request
May 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cover all official extensions to make sure we don't have similar bugs (and don't get those in the future)