Narrow explode() result for limit 0, 1, and -1#5993
Merged
VincentLanglet merged 1 commit intoJul 5, 2026
Conversation
VincentLanglet
left a comment
Contributor
There was a problem hiding this comment.
We need assertion on
explode("\n", $s, -1)
without the str_contains check
0fa6aac to
cc31f25
Compare
Contributor
Author
|
Added: |
staabm
approved these changes
Jul 5, 2026
VincentLanglet
approved these changes
Jul 5, 2026
Contributor
|
Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #5959, refining
explode()'s return type for small limits, per theexplode()manual:0or1returns the whole string unsplit (a limit of0is treated as1), so the result is the single-element shapearray{string}instead ofnon-empty-list<string>. This holds regardless of whether the delimiter is present.-1with a delimiter proven present drops only the last of the (at least two) parts, leaving at least one, sonon-empty-list<string>instead oflist<string>. Limit-2and beyond can still empty the result and staylist<string>.