Consider adding a `matchConditionsMatchingType` rule?

[pkly]

Hello,

I was looking through the rules and loved the switchConditionsMatchingType rule, as we just had a problem with exactly that, and I was wondering if it'd be possible to get a rule for matches too?

https://phpstan.org/r/3afb2b5f-392a-4fa4-8017-1eeb9ad95af0

Something like this would act as a reproducer, the only real issue is it would only work with simple matches, not something with complex expressions, but I feel like it could still be helpful.

I could also maybe work on it sometime, if you'd consider adding it to this repository.

[ondrejmirtes]

What error do you expect? There's already:

Match arm comparison between Foo::Bar|Foo::Baz and 'bar' is always false.

[pkly]

I'm not fully sure if what I'm describing would be fully covered by existing rules, to be honest.

Maybe it could check if the cases inside of match are simple values, if they're the same type as the value passed to match, assuming there are no expressions.

[ondrejmirtes]

I don't get it. You should describe what errors you expect to be reported in a code snippet. I don't have a 🔮 to read your mind 😊

[github-actions]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.