Allow to increment strings#200
Merged
Merged
Conversation
staabm
reviewed
Jan 18, 2023
| return true; | ||
| } | ||
|
|
||
| if ($type instanceof StringType) { |
Contributor
There was a problem hiding this comment.
Suggested change
| if ($type instanceof StringType) { | |
| if ($type->isString()->yes()) { |
Contributor
Author
There was a problem hiding this comment.
Thanks, changed
ondrejmirtes
requested changes
Jan 18, 2023
VincentLanglet
force-pushed
the
stringIncrement
branch
from
392c32d to
da33344
Compare
VincentLanglet
force-pushed
the
stringIncrement
branch
from
da33344 to
4b09183
Compare
VincentLanglet
requested review from
ondrejmirtes and
staabm
and removed request for
ondrejmirtes and
staabm
Member
|
Thank you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #174
1.5.x seemed to be the default branch but I can also open the PR on 1.4.x