Add operand in ternary operators rule

[dmytro-dymarchuk]

Find unnecessary ternary operators, when if and else part are equal or if and else part could be replaced by condition casted to bool.

[carusogabriel]

@dmitrydymarchuk This is already handled by https://github.com/slevomat/coding-standard#slevomatcodingstandardcontrolstructuresdisallowshortternaryoperator-. Also, using the short ternary operator ?: isn't really safe, as you can hide some boolean cases inside the first member.

[dmytro-dymarchuk]

@carusogabriel PHPStan can be used without PHP CodeSniffer. I think phpstan-strict-rules should return error for shorthand operator in this case.

[ondrejmirtes]

Hi, I agree with this part If and else parts of ternary operator are equal (%s). but not with Ternary operator is not needed.. PHPStan isn't a codestyle tool so this requirement is too opinionated.

[dmytro-dymarchuk]

Ternary operator is not needed.

This part was removed

[ondrejmirtes]

Thank you!

[ondrejmirtes]

Hi, unfortunately I had to revert this rule (03807e3). It finds false positives in cases like:

function (\stdClass $a, \stdClass $b): void {
    rand(0, 1) ? [$a] : [$b];
};

Unfortunately PHPStan\Type\Type has no method to handle these scenarios which would be required to check whether some value is identical or not.