Skip to content

Conversation

@localheinz
Copy link
Contributor

This PR

  • caches dependencies installed with composer between builds


cache:
directories:
- $HOME/.composer/cache

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not $HOME/.composer? And then hirak/prestissimo in before_install.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wouldn't complicate it with that, cache is enough.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even this whole cache doesnt really provide too much speed benefit actually, composer already caches a lot internally.

@ondrejmirtes
Copy link
Member

Thanks!

@ondrejmirtes ondrejmirtes merged commit cda85d5 into phpstan:master Feb 9, 2019
@localheinz localheinz deleted the feature/cache branch February 9, 2019 13:05
@localheinz
Copy link
Contributor Author

Thank you, @dereuromark, @kubawerlos, @and @ondrejmirtes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants