Skip to content

Conversation

@DaDeather
Copy link

@DaDeather DaDeather commented Jan 20, 2022

Hi there.

we were in need of this feature to detect possible dead route generation when using dynamicly generated route "name"s through symfony by its namespace_controller_method style.

Therefore I've created this simple analysis which I would like to share with anyone in the same need.

@DaDeather DaDeather force-pushed the add-analysis-for-route-generation branch from b5d7311 to d35cd60 Compare January 20, 2022 20:28
@DaDeather DaDeather force-pushed the add-analysis-for-route-generation branch from d35cd60 to 2892226 Compare January 25, 2022 06:58
@DaDeather
Copy link
Author

@ondrejmirtes would this feature be something you would see in this project?

@ondrejmirtes
Copy link
Member

I need @lookyman to look at this, I'm not able to evaluate it myself as I personally don't use Symfony. Thanks.

@DaDeather
Copy link
Author

@lookyman did you had any chance to look over it or at least for letting me know if this might be a feature of relevance for this plugin?

@lookyman
Copy link
Collaborator

lookyman commented Feb 2, 2022

I did have a look. It's an OK feature, but to be honest, it's pretty specific use case, and I'm not sure I really want to maintain it here..

@DaDeather
Copy link
Author

I did have a look. It's an OK feature, but to be honest, it's pretty specific use case, and I'm not sure I really want to maintain it here..

It is definitely a specific feature and I fully understand the maintaining issue here. I will outsource it to another repository than to allow others to use / copy / extend it by need.
Thank you guys for all your work!

@DaDeather DaDeather closed this Feb 7, 2022
@DaDeather
Copy link
Author

For anyone interested in such a feature - here's the package:
https://packagist.org/packages/dadadev/phpstan-symfony-routing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants