Skip to content

Conversation

@viviengaetan
Copy link
Contributor

Fix for #344

Adding method __toString() to Validator Stubs according to real Interface

I added some missing part too but I'm not sure if it can break anything in older Symfony / PHP. I can keep it to only adding method if that's needed

@ondrejmirtes ondrejmirtes merged commit 4f984e5 into phpstan:1.2.x Jul 20, 2023
@ondrejmirtes
Copy link
Member

Thank you.

@VincentLanglet
Copy link
Contributor

HI @ondrejmirtes,

This (and some other feature maybe) was merge in 1.2.x but doesn't appear in any tags
https://github.com/phpstan/phpstan-symfony/releases

And there are some 1.3.x tags, but the default branch of https://github.com/phpstan/phpstan-symfony seems to be 1.2.x.

Does the 1.2.x branch should be merged into 1.3.x, the 1.3.x used as a default and a new tag done or something else ?

Thanks.

@ondrejmirtes
Copy link
Member

@VincentLanglet Either I need to do some branch reshuffling, or this will have to wait after PHPStan 1.11 is released this fall.

@VincentLanglet
Copy link
Contributor

@VincentLanglet Either I need to do some branch reshuffling, or this will have to wait after PHPStan 1.11 is released this fall.

Oh, I see 1.3.2...1.2.x

Your call. I'll ignore my errors until the new release.
Thanks for the quick answer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants