Infer type for builder getData #371
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VincentLanglet
commented
Nov 6, 2023
Comment on lines
+32
to
+33
| assertType('GenericFormDataType\DataClass|null', $builder->getData()); | ||
| assertType('GenericFormDataType\DataClass|null', $builder->getForm()->getData()); |
Contributor
Author
There was a problem hiding this comment.
Unfortunately this can be null for embedded form, cf
symfony/symfony#5694
symfony/symfony#28741
https://stackoverflow.com/questions/21862168/calling-builder-getdata-from-within-a-nested-form-always-returns-null
VincentLanglet
force-pushed
the
formBuilder
branch
from
2cbcee7 to
ee0e67c
Compare
Contributor
|
Thank you for continuing this! Tighten form types are so great, LGTM. |
Contributor
Author
So I think it's ready for your review @ondrejmirtes |
ondrejmirtes
requested changes
Jan 6, 2024
Member
ondrejmirtes
left a comment
ondrejmirtes
left a comment
There was a problem hiding this comment.
Please base this on 1.3.x
VincentLanglet
force-pushed
the
formBuilder
branch
from
108e0b2 to
e147b54
Compare
Contributor
Author
Done |
ondrejmirtes
approved these changes
Jan 10, 2024
Member
|
Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried to continue the PR #337
cc @siketyan, do you think this change is ok ?