Skip to content

Remove unnecessary ServiceSubscriberInterface stub#480

Merged
VincentLanglet merged 1 commit intophpstan:2.0.xfrom
stof:remove_unnecessary_stub
Apr 22, 2026
Merged

Remove unnecessary ServiceSubscriberInterface stub#480
VincentLanglet merged 1 commit intophpstan:2.0.xfrom
stof:remove_unnecessary_stub

Conversation

@stof
Copy link
Copy Markdown
Contributor

@stof stof commented Apr 21, 2026

This stub does not override any upstream types and is not necessary for the stubbed methods of AbstractController.

@stof
Copy link
Copy Markdown
Contributor Author

stof commented Apr 21, 2026

As discussed in the Symfony Slack #static-analysis channel, stub classes don't need to implement the interfaces that are implemented in the actual interface (they are partial stubs after all), unless they reference them in @implements to provide the generic types (which is not the case here)

@VincentLanglet
Copy link
Copy Markdown
Contributor

Hi, can you rebase ; thanks

This stub does not override any upstream types and is not necessary for
the stubbed methods of AbstractController.
@stof stof force-pushed the remove_unnecessary_stub branch from 394087b to 94c1438 Compare April 22, 2026 15:06
@stof
Copy link
Copy Markdown
Contributor Author

stof commented Apr 22, 2026

@VincentLanglet done

@VincentLanglet VincentLanglet merged commit 35314e0 into phpstan:2.0.x Apr 22, 2026
43 checks passed
@stof stof deleted the remove_unnecessary_stub branch April 22, 2026 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants