Fix the tests running the extension without the container#484
Merged
VincentLanglet merged 1 commit intophpstan:2.0.xfrom Apr 22, 2026
Merged
Fix the tests running the extension without the container#484VincentLanglet merged 1 commit intophpstan:2.0.xfrom
VincentLanglet merged 1 commit intophpstan:2.0.xfrom
Conversation
PHPunit expects test classes to have a `Test` suffix in their name by default. Other classes are not loaded (considering they are utilities or fixtures for the tests instead).
stof
commented
Apr 22, 2026
| } | ||
|
|
||
| yield from $this->gatherAssertTypes(__DIR__ . '/data/ExampleController.php'); | ||
| yield from $this->gatherAssertTypes(__DIR__ . '/data/ExampleControllerWithoutContainer.php'); |
Contributor
Author
There was a problem hiding this comment.
Those were using the files defining assertions with precise container-based types instead of the dedicated assertions. This was not caught because the test never actually ran due to the class name not making it a test class.
VincentLanglet
approved these changes
Apr 22, 2026
Contributor
|
Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PHPunit expects test classes to have a
Testsuffix in their name by default. Other classes are not loaded (considering they are utilities or fixtures for the tests instead).