Skip to content

Load more form stubs conditionally#485

Merged
staabm merged 1 commit intophpstan:2.0.xfrom
stof:conditional_form_stubs
Apr 24, 2026
Merged

Load more form stubs conditionally#485
staabm merged 1 commit intophpstan:2.0.xfrom
stof:conditional_form_stubs

Conversation

@stof
Copy link
Copy Markdown
Contributor

@stof stof commented Apr 22, 2026

The FormView has upstream types. (needed as dependencies of form type stubs)
The exception stubs are only needed as dependencies of the DataTransformerInterface stubs.

I missed those in #481.

Copy link
Copy Markdown
Contributor

@VincentLanglet VincentLanglet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FormView stub is used in the generics

See phpstan build

@stof
Copy link
Copy Markdown
Contributor Author

stof commented Apr 22, 2026

I'll revert that part then. Seems like I did not actually missed it in the previous PR.

@stof stof force-pushed the conditional_form_stubs branch from 6247922 to b05e4cc Compare April 24, 2026 09:15
The exception stubs are only needed as dependencies of the
`DataTransformerInterface` stubs.
@stof stof force-pushed the conditional_form_stubs branch from b05e4cc to 9087e0c Compare April 24, 2026 09:16
@stof
Copy link
Copy Markdown
Contributor Author

stof commented Apr 24, 2026

@VincentLanglet I updated the PR to keep the FormView stub

@VincentLanglet VincentLanglet requested a review from staabm April 24, 2026 11:02
@staabm staabm merged commit 809c1e6 into phpstan:2.0.x Apr 24, 2026
43 checks passed
@staabm
Copy link
Copy Markdown
Contributor

staabm commented Apr 24, 2026

Thank you

@stof stof deleted the conditional_form_stubs branch April 24, 2026 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants