cannot store `phpstan-assert-if-true` result in a variable

[nikophil]

Bug report

When calling a function which has a phpstan-assert-if-true annotation, if the result of the function is stored in a variable, PHPStan should know about the "narrowed" type, when the variable is tested.

Code snippet that reproduces the problem

https://phpstan.org/r/62ff0a37-00d7-40bf-9498-70d1d48e0844

Expected output

the second and third dumpType() should also resolve to string

Did PHPStan help you today? Did it make you happy in any way?

thanks for your excellent work

[phpstan-bot]

@nikophil After the latest push in 2.1.x, PHPStan now reports different result with your code snippet:

@@ @@
+PHP 8.2 – 8.3 (4 errors)
+==========
+
+11: Function assertStringNotNull() never returns false so the return type can be changed to true.
+18: Dumped type: string
+24: Dumped type: string|null
+29: Dumped type: string|null
+
+PHP 7.2 – 8.1 (3 errors)
+==========
+
 18: Dumped type: string
 24: Dumped type: string|null
 29: Dumped type: string|null

Full report

PHP 8.2 – 8.3 (4 errors)

Line	Error
11	Function assertStringNotNull() never returns false so the return type can be changed to true.
18	Dumped type: string
24	`Dumped type: string
29	`Dumped type: string

PHP 7.2 – 8.1 (3 errors)

Line	Error
18	Dumped type: string
24	`Dumped type: string
29	`Dumped type: string

[phpstan-bot]

Closed via merging phpstan/phpstan-src#4988