Doctrine's Collection not recognized as array

[Aerendir]

I have this code:

/**
 * @ORM\Entity
 * @ORM\Table(name="users")
 */
class User extends BaseUser
{
...
    /**
     * @return Collection|Email[]
     */
    public function getEmails(): Collection
    {
        return $this->emails;
    }
...
}

class OrderVoter extends Voter
{
...
    /**
     * @param Order $order
     * @param User        $user
     *
     * @return bool
     */
    private function isBillee(Order $order, User $user): bool
    {
        return in_array($order->getSrcBillingEmail(), $user->getEmails(), true);
    }

    /**
     * @param Order $order
     * @param User        $user
     *
     * @return bool
     */
    private function isConsignee(Order $order, User $user): bool
    {
        return in_array($order->getSrcShippingEmail(), $user->getEmails(), true);
    }
...
}

The errors I receive are those:

 ------ ------------------------------------------------------------------------------------------------------------------------------------- 
  Line   Security/RemoteOrderVoter.php                                                                                                        
 ------ ------------------------------------------------------------------------------------------------------------------------------------- 
  127    Parameter #2 $haystack of function in_array expects array, Doctrine\Common\Collections\Collection&iterable<App\Entity\Email> given.  
  138    Parameter #2 $haystack of function in_array expects array, Doctrine\Common\Collections\Collection&iterable<App\Entity\Email> given.  
 ------ ------------------------------------------------------------------------------------------------------------------------------------- 

Lines refers to the two methods OrderVoter::isBillee() and OrderVoter::isConsignee().

I've tried to reproduce (for what is possible) the issue here:

https://phpstan.org/r/b7dfa46b-ba40-4f10-9720-093c0258ff19

Any ideas about how to solve those errors?

I'm using version 0.11.6 of PHPStan.

[ondrejmirtes]

PHPStan is correct here. You really cannot pass Doctrine\Common\Collections\Collection into in_array.

You also really shouldn't check for objects using in_array (and third parameter true) because it will only find exactly the same instances of objects. It's equivalent to ===.

new Email('foo@foo.com') === new Email('foo@foo.com') is false.

Your code is broken a lot.

[Aerendir]

Ok, you are right: I've just refactored with Rector and it changed my code this way... I didn't really think about it in a hurry: I've to come back to the old code... Thank you!

[ondrejmirtes]

cc @TomasVotruba

[Aerendir]

Anyway the code is not broken as they are entities and so are always the same object once fetched from the database 😅

[ondrejmirtes]

Yes, if the email is an entity then it’s fine but let’s hope this requirement is always met 😊

On Mon, 3 Jun 2019 at 17:14, Adamo Crespi ***@***.***> wrote: Anyway the code is not broken as they are entities and so are always the same object once fetched from the database 😅 — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub <#2176?email_source=notifications&email_token=AAAZTOGURXCE3XQ6OL3GXJTPYUYN3A5CNFSM4HSI63I2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODWZXHTI#issuecomment-498299853>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAAZTOESKCCN6J25PRG57WDPYUYN3ANCNFSM4HSI63IQ> .

-- Ondřej Mirtes