Errors missed on arrow functions

[nicofff]

Bug report

Under some circumstances, the same implementation using anonymous functions will detect an issue, but if arrow functions are used, it won't.

Code snippet that reproduces the problem

https://phpstan.org/r/8dd5b2a8-e742-4577-b00a-b2bfc72184d5

Expected output

I'd expect both array_map's to raise the same issue, since the code is equivalent.

[ondrejmirtes]

The ArrowFunction needs similar handling as the Closure node has here: https://github.com/phpstan/phpstan-src/blob/a23f80828620e663c67bbacdcb246b888db158a4/src/Analyser/NodeScopeResolver.php#L2093-L2101 (+ where the $callableParameters are used: https://github.com/phpstan/phpstan-src/blob/a23f80828620e663c67bbacdcb246b888db158a4/src/Analyser/NodeScopeResolver.php#L2140

[phpstan-bot]

@nicofff PHPStan now reports different result with your code snippet:

@@ @@
-5: Parameter #1 $string of function strlen expects string, int given.
+PHP 7.4 – 8.0 (1 error)
+==========
+
+5: Parameter #1 $string of function strlen expects string, int given.
+
+PHP 7.1 – 7.3 (2 errors)
+==========
+
+4: Syntax error, unexpected ',' on line 4
+4: Syntax error, unexpected T_DOUBLE_ARROW, expecting ')' on line 4

Full report

PHP 7.4 – 8.0 (1 error)

Line	Error
5	Parameter #1 $string of function strlen expects string, int given.

PHP 7.1 – 7.3 (2 errors)

Line	Error
4	Syntax error, unexpected ',' on line 4
4	Syntax error, unexpected T_DOUBLE_ARROW, expecting ')' on line 4

[phpstan-bot]

@nicofff After the latest commit in dev-master, PHPStan now reports different result with your code snippet:

@@ @@
-5: Parameter #1 $string of function strlen expects string, int given.
+PHP 7.4 – 8.0 (2 errors)
+==========
+
+4: Parameter #1 $string of function strlen expects string, int given.
+5: Parameter #1 $string of function strlen expects string, int given.
+
+PHP 7.1 – 7.3 (2 errors)
+==========
+
+4: Syntax error, unexpected ',' on line 4
+4: Syntax error, unexpected T_DOUBLE_ARROW, expecting ')' on line 4

Full report

PHP 7.4 – 8.0 (2 errors)

Line	Error
4	Parameter #1 $string of function strlen expects string, int given.
5	Parameter #1 $string of function strlen expects string, int given.

PHP 7.1 – 7.3 (2 errors)

Line	Error
4	Syntax error, unexpected ',' on line 4
4	Syntax error, unexpected T_DOUBLE_ARROW, expecting ')' on line 4

[github-actions]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.