Undetected template invariance violation with arrays

[dktapps]

Bug report

Code snippet that reproduces the problem

https://phpstan.org/r/07963c2f-f876-48b9-bc8b-e1f9a7448c00

Expected output

An error should be reported on line 35, because array<WorldProviderEntry<WorldProvider>> cannot accept WorldProviderEntry<T of WorldProvider>. The additional code at the end provides reasoning why.

Footnote

I guess this should be allowed if template-covariant was used on the WorldProviderManagerEntry class?

[phpstan-bot]

@dktapps After the latest commit in dev-master, PHPStan now reports different result with your code snippet:

@@ @@
 36: Dumped type: WorldProviderManagerEntry<T of WorldProvider (method WorldProviderManager::addProvider(), argument)>
-37: Dumped type: array<string, WorldProviderManagerEntry<WorldProvider>>&nonEmpty
+37: Dumped type: non-empty-array<string, WorldProviderManagerEntry<WorldProvider>>

Full report

Line	Error
36	Dumped type: WorldProviderManagerEntry<T of WorldProvider (method WorldProviderManager::addProvider(), argument)>
37	Dumped type: non-empty-array<string, WorldProviderManagerEntry<WorldProvider>>

[phpstan-bot]

Closed via merging phpstan/phpstan-src#5399