Fix module caching & memory leaks #150
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without the compare function std::map simply compares one pointer to another. However we need to compare the actual strings. Besides we must not efree normalised_module_id on return of require method, since the pointer was added to modules_loaded (and is valid until destruction of V8Js class); instead it is now freed during V8Js object destruction.
The garbage collector cannot free the object as it is allocated on the local stack.
The strlen usage on term obviously was wrong here, since the term string is not null-terminated at that place.
stesie
added a commit
that referenced
this pull request
Aug 3, 2015
Fix module caching & memory leaks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
std::mapdefault behaviour of pointer comparison)After all this might be bit of a backwards incompatible change, that caching is now applied correctly (and some code might rely on caching not to work). Contrary without this patch chances are that two distinctly named modules are collapsed & cached, if both used the exact same pointer (which could happen due to a use-after-free issue)
@pinepain would you like to give it a try?
This fixes #140