Cache v8::FunctionTemplates created by v8js_named_property_callback #161
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stesie
added a commit
that referenced
this pull request
Aug 27, 2015
Cache v8::FunctionTemplates created by v8js_named_property_callback
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If JavaScript code repeatedly calls a PHP method on an object exported to V8,
v8js_named_property_callbackcurrently generates a newv8::FunctionTemplatefor each successive call. However thosev8::FunctionTemplateobjects are not subject to garbage collection, hence we leak memory on every method get ... which can become a problem quickly.This patch adds FunctionTemplate caching quite like we already do for exported PHP objects themselves.