Cache pseudo-Array FunctionTemplate as well #163
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stesie
added a commit
that referenced
this pull request
Sep 1, 2015
Cache pseudo-Array FunctionTemplate as well
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was already noted
@todoin the code, but never implemented.Currently we create a new
v8::FunctionTemplateon every export of a PHP array to V8. Unfortunately those are not object to garbage collection, hence it is a particular bad to repeatedly create those templates, if the PHP code exports millions of arrays to V8 :-)Now the global
v8js_ctxhas a persistent refernce to theFunctionTemplate, which now is initialized on first Array-export to V8. Succeeding exports re-use the template; and finally the reference is cleared on isolate deconstruction.