Added ability to set properties on V8Function #173
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stesie
added a commit
that referenced
this pull request
Nov 3, 2015
Added ability to set properties on V8Function
Member
|
Very nice catch and definitely a lacking feature :-) Thank you @kynx! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Beware: I am not a C++ programmer! But I was curious how easy it would be to fix #172 and had a look through the
v8js_v8jsobject_(has|read|write|unset)_propertycode. I got wondering what would happen if I just stripped out the&& !v8obj->IsFunction()conditions.And blow me, it seems to work! Maybe this is a really really bad idea, but here it is.