-
Notifications
You must be signed in to change notification settings - Fork 204
PHP 7.4 support #440
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PHP 7.4 support #440
Conversation
84dcbb0 to
6b812d4
Compare
|
Current version runs just fine on old PHP versions (and V8 7.5), like Travis shows us. V8 7.5 with ppa:ondrej/php 7.4 however does not work correctly. It keeps crashing ... yet looks completely unrelated to v8js (on first sight?) Contrary I can not reproduce this with self-compiled PHP 7.4.4 with |
|
For the moment I'll give up trying to reproduce the above behaviour. Maybe some patch the apply before packaging, ... Build with self-compiled PHP + ASAN is green: https://jenkins.brokenpipe.de/job/v8js-github-stesie/job/php-7.4-support/2/ ... so merging now. V8 8.0 isn't working properly though |
|
... if someone manages to reproduce the ondrej bug with a known codebase (and at best running ASAN yourself), let me know/open a specific issue |
closes #430
closes #409