Feature/modernize #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
@colinodell can you review this? |
|
Yeah! If not tonight then definitely tomorrow.
On Tue, Jan 1, 2019, 15:08 Matt Trask ***@***.***> wrote:
@colinodell <https://github.com/colinodell> can you review this?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#2 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAMVMsaGc8QuGgwrdvpLQ-o5fCh6BXbQks5u-8AmgaJpZM4ZmAzt>
.
--
Colin O'Dell
colinodell@gmail.com
https://www.colinodell.com
|
colinodell
reviewed
Jan 2, 2019
colinodell
left a comment
colinodell
left a comment
There was a problem hiding this comment.
Overall this looks pretty good - nice work! I did leave a few minor comments.
Also, at some point, I think we should maybe add tests for older PHP versions too to check for possible BC breaks.
Author
|
@colinodell sorry it took a while, but these are taken care of. Agreed on regression tests as well. Ill make an issue. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.