Airport Lookup returns Non-ICAO codes

[FatihKoz]

During flight plan import via csv file, airport lookup returns some internal data (from the source directly) as "ICAO" code of the airport and a new airport gets created with that "ID", and when another lookup is done while processing next/another row with the same airport, import fails with server error.

SQLSTATE: Integrity constraint violation: 1062 Duplicate entry 'TR-0017' for key 'PRIMARY' (Connection: mysql, SQL: insert into `airports` (`id`, `icao`, `iata`, `name`, `country`, `timezone`, `lat`, `lon`, `region`, `elevation`, `location`) values (TR-0017, TR-0017, BGG, Bingöl Airport, TR, , 38.860131, 40.594489, TR-12, 3506, Bingöl)) {"userId":2,"exception":"[object] (Illuminate\\Database\\UniqueConstraintViolationException(code: 23000): SQLSTATE: Integrity constraint violation: 1062 Duplicate entry 'TR-0017' for key 'PRIMARY' (Connection: mysql, SQL: insert into `airports` (`id`, `icao`, `iata`, `name`, `country`, `timezone`, `lat`, `lon`, `region`, `elevation`, `location`) values (TR-0017, TR-0017, BGG, Bingöl Airport, TR, , 38.860131, 40.594489, TR-12, 3506, Bingöl))

Here in this example, lookup is done for LTCU , which is BGG / Bingol Airport, but the lookup returns TR-0017 instead. As we look for LTCU in our records to trigger a lookup it is done again.

So either the source should be fixed or we need to have something specific to fix this kind of "external source" errors.

Version
7.0.3

To Reproduce
Steps to reproduce the behavior:

1. Create a csv file with LTCU airport either as dep or arr
2. Import that file
3. See the error

Expected behavior
Fake ID's of external sources or non-proper ICAO codes should not be used

[nabeelio]

From the vacentral lookup?

[FatihKoz]

From the vacentral lookup?

Of course, there are no other lookup sources in phpVMS v7.

[FatihKoz]

Above mentioned vaCentral lookup and non-standard results (of external data) bug also effects vmsAcars usage.

[FatihKoz]

https://discord.com/channels/332920618729340929/736786871841062962/1358088544509362246

[arthurpar06]

Is this still relevant? When I do a lookup for LTCU, I do find LTCU. If I remember correctly, @nabeelio changed the airport sources in vacentral a few weeks/months ago

[FatihKoz]

Unconfirmed ? This is a confirmed issue.

We need to check the latest source to be sure, If it does not have strange id or codes then we can consider it fixed :)

Do you have a link for the raw source so I can check ?

[arthurpar06]

Sorry, I marked it as unconfirmed to indicate that I triaged it but wasn’t sure if it was still relevant (i.e., unconfirmed whether the bug still exists in the latest version).

Here’s the URL used by lookup in v7, so I guess it would be: https://api.vacentral.net/api/airports/{icao}
https://github.com/phpvms/vacentral-library/blob/master/src/VaCentral.php#L88

[FatihKoz]

I was asking about the "changed" source, not the code of our lookup mate :)

Before it was mixed, later on Nabeel changed it to OurAirports (or something similar), which was the problem itself. Open source, no proper checks, no legal backend, anyone can enter data and it had lots of wrong entries, thus caused problems. In short, it was not a reliable source.

Now you said that Nabeel changed it again recently, I am asking about that source. The source of VaCentral, if you have it we can check together and I can provide some AIRAC valid data to compare ;)

[arthurpar06]

Oops sorry, looks like i was tired and didn't understand. As far as I remember, he was using a combination of mwgg and ourairports. MWGG was the issue and therefore he is simply using ourairports now.