Merged
Conversation
jablan
requested review from
Hassan Ahmed (hahmed-dev) and
Sönke Behrendt (theSoenke)
Collaborator
|
jablan great we could keep the existing interfaces with the latest generator 🔥 do you think it would make sense to add those tests first before we merge this to check that they pass before and after? |
Collaborator
Author
|
Sönke Behrendt (@theSoenke) that'd be great, if can be done in this sprint. |
Hassan Ahmed (hahmed-dev)
approved these changes
Oct 30, 2023
Contributor
Hassan Ahmed (hahmed-dev)
left a comment
Hassan Ahmed (hahmed-dev)
left a comment
There was a problem hiding this comment.
Looks good for the most part! Great Job!!
Sönke Behrendt (theSoenke)
approved these changes
Oct 30, 2023
Collaborator
Sönke Behrendt (theSoenke)
left a comment
Sönke Behrendt (theSoenke)
left a comment
There was a problem hiding this comment.
🚀 also want to bump the library versions in this PR already?
This was referenced Oct 30, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Big bump for openapi-generator from v4.3 to v7. Tried to keep the generated code as close as possible, by modifying the templates which have previously been dumped to
openapi-generator/templatesfolder.For comparing results, I was checking out another copy of this project, generating the libraries, and then running a recursive folder comparison tool.