feat(API): Add use_ordinal_rules boolean [STRINGS-2273]#846
feat(API): Add use_ordinal_rules boolean [STRINGS-2273]#846Ildar Safin (ildarsafin) merged 3 commits intomainfrom
Conversation
Ildar Safin (ildarsafin)
changed the title
| type: string | ||
| plural: | ||
| type: boolean | ||
| use_ordinal_rules: |
There was a problem hiding this comment.
perhaps also add in the example below?
There was a problem hiding this comment.
yes I think it should be added there as well
Ildar Safin (ildarsafin)
requested review from
Mikko Karkee (Varpuspaavi) and
Hassan Ahmed (hahmed-dev)
| type: array | ||
| items: | ||
| type: string | ||
| ordinal_plural_forms: |
There was a problem hiding this comment.
This is not public for everyone yet, so we should not expose it on our api docs or libraries.
There was a problem hiding this comment.
Yes, it will be also revealed after the feature toggle removal. I think it's better to have it prepared and reviewed beforehand so it can be easily merged after the release.
There was a problem hiding this comment.
But I agree that the bigger features should not be exposed to the public for sure 👍
| - zero | ||
| - one | ||
| - other | ||
| plural_ordinal_forms: |
There was a problem hiding this comment.
should be ordinal_plural_forms instead, right?
There was a problem hiding this comment.
Good point! Just fixed it.
Ildar Safin (ildarsafin)
removed
the
DONT MERGE
3 participants
use_ordinal_rulesboolean is used to define whether is using ORDINAL or CARDINAL pluralization rules.Add
ordinal_plural_formsto locales endpoint.