fix(CLI): segfault on pull with branch argument #955
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a segmentation fault that occurs when using the pull command with the --branch argument when the Params field is not initialized in the target configuration.
Key Changes:
- Added nil check for
target.Paramsbefore accessing it to prevent segfault - Initialize
target.Paramswith emptyPullParamsstruct when nil
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
BlumMichael
approved these changes
Nov 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
if
target.Paramsis not there (missing section in the config),pull --branch ...segfaultsphrase/phrase-cli#174