Unity 2019 compatibility#24
Merged
Matias Alvarez (malvarezphrase) merged 1 commit intomainfrom Oct 22, 2024
Merged
Conversation
Matias Alvarez (malvarezphrase)
approved these changes
Oct 22, 2024
Matias Alvarez (malvarezphrase)
deleted the
598-unity-2019-compatibility
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Seems that older Unity versions use older C#, not allowing for some syntax that we were using in the plugin.
Also, parts of Unity Localization package aren't exposed to versions before 2020.3. I managed to selectively disable part of the plugin relying on these classes so that the plugin still runs in older versions, without affecting the functionality in the newer versions.
Would be nice for this to be QA-ed.
https://phrase.atlassian.net/browse/STRINGS-598