Update from upstream v1.1.0 #4
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves PropType deprecation warning
Fix scroll focus when using up arrow key
Remove obsolete browserify-shim configuration
Remove obsolete browserify-shim configuration
fix bug, if wrote "hasOwnProperty"
…#1951. Ran this locally and compared each of the demos against the live version and saw no differences.
…selector-scoping Fixing css states to be scoped with Select selector, closes JedWatson#1951.
Fix test name
Addresses JedWatson#2009. There is a WIP test -- I can't figure out how to simulate the exact scenario that this patch fixes in the test. The current test returns positive even without my change. Suggestions would be appreciated -- thanks!
Addresses the second issue mentioned in the linked issue. While the previous commit makes this change unnecessary for regular use cases, the issue is still present when debouncing. By clearing out `this._callback`, intermediary searches (e.g. 'Ti' when 'Tim' is already fetched) won't cause the options for 'Tim' to change when the request for 'Ti' completes.
Without key prop the input element unmounted and remounted after input changed, and the "onblur" handler make the panel dismissed soon.
It seems that the version stated on the README cannot be found, but react-select@1.0.0-rc.10 is the latest version.
Correct release candidate version on README
…rash Fix/is option unique crash
…value Clear input value on receiving props with another value.
As suggested by @yuri-sakharov
As suggested by @yuri-sakharov
Don't open drop down menu when clear values
onSelectResetsInput regression fixed
Refactored handleKeyDown switch
Pass placeholder prop to ValueComponent
…sets-input-for-single Regression fix for single select with onSelectResetsInput=false
…to feature/async-pagination
…stream-1.1.0 # Conflicts: # README.md # dist/react-select.css # dist/react-select.js # dist/react-select.min.css # dist/react-select.min.js # examples/dist/app.js # examples/dist/bundle.js # examples/dist/common.js # examples/dist/standalone.js # lib/Async.js # lib/Creatable.js # lib/Select.js # package.json # src/Creatable.js # src/Select.js # test/Async-test.js
benbeadle
approved these changes
Jan 3, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
37 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I merged from the latest version of the
async-paginationPR, which has been updated to support the module's recent v1.1.0 release. (it's finally out of 1.0 limbo!)This also explicitly supports React 16 as a peerDependency (previously, I think React 16 worked, but raised a warning on install).