feat: coordinate phylum-ci Docker image releases with new CLI releases#466
Merged
Conversation
Add a repository dispatch event trigger to the release workflow. It triggers the Docker workflow in the `phylum-dev/phylum-ci` repo to build and push Docker images containing the latest `phylum` Python package and the Phylum CLI version from the tag that caused the Release workflow to run. The trigger is a simple curl command that POSTs to the `dispatches` endpoint with the expected payload. The trigger is further limited so that it will not fire for pre-releases of the CLI.
Merged
4 tasks
cd-work
requested changes
Jun 14, 2022
* Indent long command line arguments to visually separate them * Put the trigger step in it's own job, dependent on release * Use the `ubuntu-22.04` runner to make use of newer `curl` options * Add `--no-progress-meter` option to reduce output noise
cd-work
reviewed
Jun 14, 2022
kylewillmon
previously approved these changes
Jun 14, 2022
cd-work
previously approved these changes
Jun 14, 2022
Contributor
Author
|
It turns out the following syntax is invalid for a GitHub Actions workflow: if: ! contains(github.ref, 'rc')This was discovered after merging the new Docker workflow into the After searching the docs and coming up empty, a GitHub Community Forum post for this issue (but for The same correction will be made in the |
cd-work
previously approved these changes
Jun 15, 2022
kylewillmon
previously approved these changes
Jun 15, 2022
cd-work
approved these changes
Jun 15, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a repository dispatch event trigger to the release workflow. It triggers the Docker workflow in the
phylum-dev/phylum-cirepo to build and push Docker images containing the latestphylumPython package and the Phylum CLI version from the tag that caused the Release workflow to run. Acurlcommand that POSTs to thedispatchesendpoint with the expected payload is used instead of theactions/github-scriptaction because this is a simple trigger. The trigger is further limited so that it will not fire for pre-releases of the CLI.Checklist
closes #<issueNum>in description above)?phylum-dev/phylum-ciis merged tomain