fix: include phylum-ci.exe in release artifacts#477
Merged
Conversation
This change corrects a bug in the release workflow where the `phylum-ci.exe` artifact is not published to the newly created GitHub release. The `python-semantic-release` tool has the following config, in `pyproject.toml`, for publishing artifacts by pattern: ``` [tool.semantic_release.publish] dist_glob_patterns = ["dist/*", "build/phylum-ci.exe"] ``` The issue was that the `actions/upload-artifact` step used `phylum-ci.exe` as the artifact name, which resulted in the following directory structure for the corresponding `actions/download-artifact` step: `./phylum-ci.exe/phylum-ci.exe` This clearly won't match the glob pattern of `build/phylum-ci.exe`. So, this change is a simple one: change the upload artifact name to `build` so that the downloaded artifact will exist at `./build/phylum-ci.exe`.
kylewillmon
approved these changes
Oct 2, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change corrects a bug in the release workflow where the
phylum-ci.exeartifact is not published to the newly created GitHub release. Thepython-semantic-releasetool has the following config, inpyproject.toml, for publishing artifacts by pattern:The issue was that the
actions/upload-artifactstep usedphylum-ci.exeas the artifact name, which resulted in the following directory structure for the correspondingactions/download-artifactstep:./phylum-ci.exe/phylum-ci.exeThis clearly won't match the glob pattern of
build/phylum-ci.exe. So, this change is a simple one: change the upload artifact name tobuildso that the downloaded artifact will exist at./build/phylum-ci.exe.