resources: pages: multimedia: Set default video and add toolbar subtitle#14
Merged
mschwan-phytec merged 5 commits intomainfrom Oct 20, 2023
Merged
resources: pages: multimedia: Set default video and add toolbar subtitle#14mschwan-phytec merged 5 commits intomainfrom
mschwan-phytec merged 5 commits intomainfrom
Conversation
Set the default video path to the provided example video. Signed-off-by: Martin Schwan <m.schwan@phytec.de>
Pause the video before closing the page. Signed-off-by: Martin Schwan <m.schwan@phytec.de>
Remove the play/pause button in the center of the video player as this does not work currently. Rely on the controls provided in the panel below. Signed-off-by: Martin Schwan <m.schwan@phytec.de>
Allow placing a subtitle in the toolbar. While at it, adjust the padding of the toolbar to be less wasteful. Signed-off-by: Martin Schwan <m.schwan@phytec.de>
Set the toolbar's subtitle to the currently selected video path. Signed-off-by: Martin Schwan <m.schwan@phytec.de>
andrejpicej
approved these changes
Oct 20, 2023
Contributor
andrejpicej
left a comment
andrejpicej
left a comment
There was a problem hiding this comment.
Looks good from my side, thanks.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Set the default video path to the provided example video.
Allow placing a subtitle in the toolbar. While at it, adjust the padding of the toolbar to be less wasteful. Set the toolbar's subtitle to the currently selected video path.