Skip to content

Small fixes for P244 pi-character#1790

Merged
JSMassmann merged 4 commits into
mainfrom
pi-weight-tweak
May 27, 2026
Merged

Small fixes for P244 pi-character#1790
JSMassmann merged 4 commits into
mainfrom
pi-weight-tweak

Conversation

@prabau
Copy link
Copy Markdown
Collaborator

@prabau prabau commented May 27, 2026

Continuation of #1788.

Fixed a few minor things. Specifically, the confusion in P244 between $p$ and $x$. Also added a specific page for the definition.
And some clarification and tightening of the definition (I hope).

@JSMassmann Hope you can review this. Please don't do any merging before discussing first.

@prabau prabau requested a review from JSMassmann May 27, 2026 00:05
@prabau
Copy link
Copy Markdown
Collaborator Author

prabau commented May 27, 2026

Also, is T901 (weakly first countable => countable pi-character) even correct? The $V_n(x)$ are not open sets in general.

@prabau
Copy link
Copy Markdown
Collaborator Author

prabau commented May 27, 2026

@felixpernegger Please don't approve this. Let @JSMassmann do the driving for this PR.

@JSMassmann
Copy link
Copy Markdown
Collaborator

Sure, I don't see anything wrong with these two commits.

Regarding that last comment, that's a good point, indeed the theorem is probably false but I don't have the brainpower to come up with a counterexample right now. (If I do, maybe I'll add it in another PR.) @felixpernegger wrote that theorem and I didn't bother to carefully scrutinize it, my bad.

@prabau
Copy link
Copy Markdown
Collaborator Author

prabau commented May 27, 2026

Ok, I'll remove it in this PR for now. @felixpernegger ok with you?

@prabau
Copy link
Copy Markdown
Collaborator Author

prabau commented May 27, 2026

@JSMassmann I also replaced $\pi_\chi(X)$ with $\pi\chi(X)$. I assume the first one was not intentional?

@prabau
Copy link
Copy Markdown
Collaborator Author

prabau commented May 27, 2026

I removed T901. If it turns out we were mistaken, it can be put back later.

@prabau
Copy link
Copy Markdown
Collaborator Author

prabau commented May 27, 2026

@JSMassmann You can approve the PR is you don't have any issues. Please don't merge it yet, as I will need to tell something about that step.

@prabau
Copy link
Copy Markdown
Collaborator Author

prabau commented May 27, 2026

Actually, wait. I should replace T901 with (first countable => countable pi-character).

@felixpernegger
Copy link
Copy Markdown
Collaborator

Also, is T901 (weakly first countable => countable pi-character) even correct? The V n ( x ) are not open sets in general.

I forgot about the open condition, sorry

@prabau
Copy link
Copy Markdown
Collaborator Author

prabau commented May 27, 2026

@JSMassmann For merging to the main branch, we use "squash and merge".

Important: When you click on that button, two fields appear: "Commit message" at the top and "Extended description". Before clicking "Confirm squash and merge", we normally blank out the whole extended description field, only keeping the "commit message" field. This ensures the git log is "clean".

Please take a look at the following for an explanation:
#912 (comment) and the following comment,
and #779 (comment).

Note also that sometimes we may need to edit the "commit message" field if it is not descriptive enough. (I think that sometimes if the PR has a single commit, that commit is taken as the message, instead of the PR title, which is usually more informative.) See #1557 (comment).

@JSMassmann JSMassmann merged commit 7956073 into main May 27, 2026
1 check passed
@JSMassmann JSMassmann deleted the pi-weight-tweak branch May 27, 2026 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants