Skip to content

Don't build pushes from non-org repos.#8

Merged
dschaper merged 5 commits intomasterfrom
new/travis-branch
Oct 22, 2020
Merged

Don't build pushes from non-org repos.#8
dschaper merged 5 commits intomasterfrom
new/travis-branch

Conversation

@dschaper
Copy link
Copy Markdown
Member

@dschaper dschaper commented Jul 30, 2020

No description provided.

@dschaper
Copy link
Copy Markdown
Member Author

dschaper commented Jul 30, 2020

This can merge to master or to a new branch called latest if that makes more sense. Will need to make sure the latest tag points to the right commit after merge.

@dschaper
Copy link
Copy Markdown
Member Author

dschaper commented Jul 30, 2020 •
edited
Loading

Conditionals are being seen but I think I have the wrong conditions.
Annotation 2020-07-30 130917

Trying to build all PR's and then any push that is from our repo. Not sure if that means don't build forks, or why my current regex isn't working.

https://travis-ci.com/github/pi-hole/pi-hole/requests

@dschaper
Directly specify push and repo name in compound.
b7f264f 
Signed-off-by: Dan Schaper <dan.schaper@pi-hole.net>
@dschaper dschaper mentioned this pull request Jul 31, 2020
Merged
@dschaper
Copy link
Copy Markdown
Member Author

dschaper commented Jul 31, 2020

Oh, head_repo only works for pull_request, has no function for push.

@dschaper
Push master and release or pr, api and cron.
4ad4ed2 
Signed-off-by: Dan Schaper <dan.schaper@pi-hole.net>
@dschaper
Copy link
Copy Markdown
Member Author

dschaper commented Aug 2, 2020

Commit 4ad4ed2 is tagged as latest and drafted as pre-release

@dschaper dschaper closed this Aug 2, 2020
@dschaper dschaper reopened this Aug 2, 2020
@dschaper
Copy link
Copy Markdown
Member Author

dschaper commented Aug 2, 2020

Fat finger, did not mean to close.

@dschaper
Ruby style regex.
dfbe3f8 
Signed-off-by: Dan Schaper <dan.schaper@pi-hole.net>
@dschaper
Copy link
Copy Markdown
Member Author

dschaper commented Sep 6, 2020

This is already tagged as latest so the travis builds should already be using it.

@dschaper dschaper merged commit 23e589e into master Oct 22, 2020
@dschaper dschaper deleted the new/travis-branch branch October 22, 2020 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@PromoFaux PromoFaux PromoFaux approved these changes

@bcambl bcambl Awaiting requested review from bcambl

@diginc diginc Awaiting requested review from diginc

@DL6ER DL6ER Awaiting requested review from DL6ER

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dschaper @PromoFaux