Skip to content

Conversation

@sinisaos
Copy link
Member

@sinisaos sinisaos commented Oct 14, 2024

Resolves #419

@codecov-commenter
Copy link

codecov-commenter commented Oct 14, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.02%. Comparing base (1157c12) to head (ca9fe31).
Report is 27 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #426      +/-   ##
==========================================
+ Coverage   93.42%   94.02%   +0.60%     
==========================================
  Files           5        5              
  Lines         365      402      +37     
==========================================
+ Hits          341      378      +37     
  Misses         24       24              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dantownsend
Copy link
Member

@sinisaos Thanks a lot for this - can't wait to try it.

@sinisaos
Copy link
Member Author

@dantownsend Result is this

form_group.webm

@dantownsend dantownsend changed the title group forms in the sidebar 419 Group forms in the sidebar Oct 16, 2024
@dantownsend
Copy link
Member

dantownsend commented Oct 16, 2024

@sinisaos Thanks for this. I made a couple of small changes:

  • I made a new component called SidebarGroup, so forms and tables can share some code.
  • I returned the description in the endpoint, so if you hover over the form name in the sidebar it tells you what it does.

@dantownsend dantownsend merged commit fdc55cc into piccolo-orm:master Oct 16, 2024
@sinisaos sinisaos deleted the forms_group branch October 16, 2024 21:59
@sinisaos
Copy link
Member Author

@dantownsend That's great. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Be able to group forms in the sidebar (the same way as tables)

3 participants