Skip to content

Conversation

@sinisaos
Copy link
Member

@sinisaos sinisaos commented Dec 6, 2020

Maybe it be useful to have readable column for FK in representation of single row like we have in representation of all rows in PiccoloCRUD. I'm sorry if that functionality already exist but I can't find it.

@lgtm-com
Copy link

lgtm-com bot commented Dec 6, 2020

This pull request introduces 1 alert when merging f691c00 into e90a4c5 - view on LGTM.com

new alerts:

  • 1 for Unused local variable

@dantownsend
Copy link
Member

@sinisaos Yes, this is a great suggestion. I had to refactor PiccoloCrud slightly, so that the _get_single method has access to the HTTP query parameters. This way, the behaviour can be enabled by doing /mytable/1/?__readable=true. What do you think?

I reused your code, but put it in a different branch, as the changes are easier to show in code than describe in words:

#5

Thanks :)

@sinisaos
Copy link
Member Author

sinisaos commented Dec 8, 2020

@dantownsend Great. That's exactly what I mean and your version is much better :) . You can close this pull request.

@dantownsend
Copy link
Member

Closing - used as basis for #5

@dantownsend dantownsend closed this Dec 8, 2020
@sinisaos sinisaos deleted the get-single-readable branch December 9, 2020 05:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants