Skip to content

Throttling mechanism to manage content creation abuse rate limit#113

Merged
spruce merged 1 commit intopiceaTech:masterfrom
AgnostiqHQ:throttling
Jul 27, 2022
Merged

Throttling mechanism to manage content creation abuse rate limit#113
spruce merged 1 commit intopiceaTech:masterfrom
AgnostiqHQ:throttling

Conversation

@scottwn
Copy link
Copy Markdown
Contributor

@scottwn scottwn commented Nov 25, 2021

Alternate approach to #109, using plugin-throttling minimumAbuseRetryAfter instead of sleep.

I used this discussion to guide this solution.

Fixes #28

@spruce
Copy link
Copy Markdown
Member

spruce commented Dec 6, 2021

This should be resolved with merging of #109 , right? If so, please close this PR. :)

@scottwn scottwn force-pushed the throttling branch 3 times, most recently from 1a0a60c to c945543 Compare December 8, 2021 17:49
@scottwn
Copy link
Copy Markdown
Contributor Author

scottwn commented Dec 8, 2021

I think this PR still has some worthwhile improvements:

  • Log message that communicates the length of the retry.
  • By using minimumAbuseRetryAfter instead of sleep, it allows octokit to handle the retryAfter header if it's returned by the GitHub API. Crash with abuse rate limits #28 was caused by that header not being returned in certain cases, which is why we need to add the extra delay. But in cases where the header is returned, we don't want to add more sleep on top of that.

@spruce
Copy link
Copy Markdown
Member

spruce commented Jan 10, 2022

@scottwn I'd like to merge it. Could you resolve the conflicts for that?

@spruce spruce merged commit f3a715e into piceaTech:master Jul 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Crash with abuse rate limits

2 participants